app/src/main/java/it/unisannio/ding/ids/wedroid/app/view/LoginActivity.kt

@@ -65,7 +65,7 @@ class LoginActivity : AppCompatActivity() {
 
             override fun onResponse(call: Call<UserPrototype>, response: Response<UserPrototype>) {
 
-                if (response.code() != 200) {
+                if (response.code() != HTTP_CODE_OK) {
                     Toast.makeText(
                         applicationContext,
                         R.string.login_wrong_field,
@@ -93,5 +93,6 @@ class LoginActivity : AppCompatActivity() {
     companion object {
         const val LOGIN_OK = 0
         const val LOGIN_ERROR = 1
+        const val HTTP_CODE_OK = 200
     }
 }

config/checkstyle/checkstyle.xml

@@ -54,7 +54,6 @@
             <property name="tokens"
                 value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
         </module>
-        <module name="NeedBraces"/>
         <module name="LeftCurly"/>
         <module name="RightCurly">
             <property name="id" value="RightCurlySame"/>
@@ -191,7 +190,6 @@
             <property name="allowedAbbreviationLength" value="1"/>
         </module>
         <module name="OverloadMethodsDeclarationOrder"/>
-        <module name="VariableDeclarationUsageDistance"/>
         <module name="CustomImportOrder">
             <property name="sortImportsInGroupAlphabetically" value="true"/>
             <property name="separateLineBetweenGroups" value="true"/>

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/BoardService.java

@@ -1,13 +1,17 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
-import java.util.List;
-
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Board;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.BoardPrototype;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.LabelPrototype;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.MemberPermission;
+import java.util.List;
 import retrofit2.Call;
-import retrofit2.http.*;
+import retrofit2.http.Body;
+import retrofit2.http.DELETE;
+import retrofit2.http.GET;
+import retrofit2.http.POST;
+import retrofit2.http.PUT;
+import retrofit2.http.Path;
 
 public interface BoardService {
 

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/CardCommentService.java

@@ -1,10 +1,14 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Comment;
-import retrofit2.Call;
-import retrofit2.http.*;
-
 import java.util.List;
+import retrofit2.Call;
+import retrofit2.http.DELETE;
+import retrofit2.http.Field;
+import retrofit2.http.FormUrlEncoded;
+import retrofit2.http.GET;
+import retrofit2.http.POST;
+import retrofit2.http.Path;
 
 public interface CardCommentService {
 

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/CardService.java

@@ -1,10 +1,17 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Card;
-import retrofit2.Call;
-import retrofit2.http.*;
-
 import java.util.List;
+import retrofit2.Call;
+import retrofit2.http.Body;
+import retrofit2.http.DELETE;
+import retrofit2.http.Field;
+import retrofit2.http.FormUrlEncoded;
+import retrofit2.http.GET;
+import retrofit2.http.Headers;
+import retrofit2.http.POST;
+import retrofit2.http.PUT;
+import retrofit2.http.Path;
 
 public interface CardService {
 

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/ChecklistService.java

@@ -4,10 +4,16 @@ import it.unisannio.ding.ids.wedroid.wrapper.entity.Checklist;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.ChecklistItem;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.ChecklistItemStatus;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.ChecklistPrototype;
-import retrofit2.Call;
-import retrofit2.http.*;
-
 import java.util.List;
+import retrofit2.Call;
+import retrofit2.http.Body;
+import retrofit2.http.DELETE;
+import retrofit2.http.Field;
+import retrofit2.http.FormUrlEncoded;
+import retrofit2.http.GET;
+import retrofit2.http.POST;
+import retrofit2.http.PUT;
+import retrofit2.http.Path;
 
 public interface ChecklistService {
 

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/ListService.java

@@ -1,11 +1,14 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
 import it.unisannio.ding.ids.wedroid.wrapper.entity.WList;
-import retrofit2.Call;
-import retrofit2.http.*;
-
 import java.util.List;
-
+import retrofit2.Call;
+import retrofit2.http.DELETE;
+import retrofit2.http.Field;
+import retrofit2.http.FormUrlEncoded;
+import retrofit2.http.GET;
+import retrofit2.http.POST;
+import retrofit2.http.Path;
 
 public interface ListService {
 

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/SwimlanesService.java

@@ -1,10 +1,14 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Swimlane;
-import retrofit2.Call;
-import retrofit2.http.*;
-
 import java.util.List;
+import retrofit2.Call;
+import retrofit2.http.DELETE;
+import retrofit2.http.Field;
+import retrofit2.http.FormUrlEncoded;
+import retrofit2.http.GET;
+import retrofit2.http.POST;
+import retrofit2.http.Path;
 
 public interface SwimlanesService {
     /**

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/api/UserService.java

@@ -3,10 +3,16 @@ package it.unisannio.ding.ids.wedroid.wrapper.api;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Action;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Board;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.User;
-import retrofit2.Call;
-import retrofit2.http.*;
-
 import java.util.List;
+import retrofit2.Call;
+import retrofit2.http.Body;
+import retrofit2.http.DELETE;
+import retrofit2.http.Field;
+import retrofit2.http.FormUrlEncoded;
+import retrofit2.http.GET;
+import retrofit2.http.Headers;
+import retrofit2.http.POST;
+import retrofit2.http.Path;
 
 public interface UserService {
 

wrapper/src/main/java/it/unisannio/ding/ids/wedroid/wrapper/entity/MemberPermission.java

@@ -4,7 +4,7 @@ public class MemberPermission {
     /**
      * The user is an admin of the board
      */
-    public final static MemberPermission ADMIN = new MemberPermission(
+    public static final MemberPermission ADMIN = new MemberPermission(
             true,
             false,
             false
@@ -13,7 +13,7 @@ public class MemberPermission {
     /**
      * The use is an normal member of the board
      */
-    public final static MemberPermission NORMAL = new MemberPermission(
+    public static final MemberPermission NORMAL = new MemberPermission(
             false,
             false,
             false
@@ -22,7 +22,7 @@ public class MemberPermission {
     /**
      * The user isn't allowed to make comments on the board
      */
-    public final static MemberPermission NO_COMMENTS = new MemberPermission(
+    public static final MemberPermission NO_COMMENTS = new MemberPermission(
             false,
             true,
             false
@@ -31,7 +31,7 @@ public class MemberPermission {
     /**
      * The user is only allowed to make comments on the board
      */
-    public final static MemberPermission COMMENT_ONLY = new MemberPermission(
+    public static final MemberPermission COMMENT_ONLY = new MemberPermission(
             false,
             false,
             true

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/BoardServiceTest.java

@@ -1,10 +1,18 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
+import static junit.framework.TestCase.assertNotNull;
+import static junit.framework.TestCase.assertTrue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Board;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.BoardBackgroundColor;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.BoardPermission;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.BoardPrototype;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.PresentParentTask;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import org.junit.After;
@@ -13,12 +21,6 @@ import org.junit.Test;
 import retrofit2.Retrofit;
 import retrofit2.converter.gson.GsonConverterFactory;
 
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
-import static org.junit.Assert.*;
-
 public class BoardServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private BoardService service = null;
@@ -59,8 +61,8 @@ public class BoardServiceTest {
         mockWebServer.enqueue(response);
 
         try {
-            List<Board> boards = service.getPublicBoards().
+            List<Board> boards = service.getPublicBoards()
-                    execute().body();
+                    .execute().body();
 
             assertNotNull(boards);
             assertEquals(2, boards.size());

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/CardCommentServiceTest.java

@@ -1,6 +1,12 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Comment;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import org.junit.After;
@@ -9,13 +15,6 @@ import org.junit.Test;
 import retrofit2.Retrofit;
 import retrofit2.converter.gson.GsonConverterFactory;
 
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-
 public class CardCommentServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private CardCommentService service = null;
@@ -110,17 +109,17 @@ public class CardCommentServiceTest {
         }
     }
 
-    private final static String COMMENT_1 = "{" +
+    private static final String COMMENT_1 = "{" +
             "\"_id\":\"zwzAgjHdW4fNJ9YLc\"," +
             "\"comment\":\"comment 1\"," +
             "\"authorId\":\"Si69gNgkJfQuk6uiJ\"" +
             "}";
-    private final static String COMMENT_2 = "{" +
+    private static final String COMMENT_2 = "{" +
             "\"_id\":\"zwzAgjHdW4fNJ9YLt\"," +
             "\"comment\":\"comment 2\"," +
             "\"authorId\":\"Si69gNgkJfQuk6uiJ\"" +
             "}";
-    private final static String COMMENT_3 = "{" +
+    private static final String COMMENT_3 = "{" +
             "\"_id\":\"DofhD9v96DbX7Wirp\"," +
             "\"userId\":\"Si69gNgkJfQuk6uiJ\"," +
             "\"text\":\"commento api\"," +

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/CardServiceTest.java

@@ -1,22 +1,20 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
-
-import it.unisannio.ding.ids.wedroid.wrapper.entity.Card;
-import retrofit2.Retrofit;
-import retrofit2.converter.gson.GsonConverterFactory;
-import okhttp3.mockwebserver.MockResponse;
-import okhttp3.mockwebserver.MockWebServer;
-
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 
+import it.unisannio.ding.ids.wedroid.wrapper.entity.Card;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
+import okhttp3.mockwebserver.MockResponse;
+import okhttp3.mockwebserver.MockWebServer;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import retrofit2.Retrofit;
+import retrofit2.converter.gson.GsonConverterFactory;
+
 public class CardServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private CardService service = null;
@@ -56,8 +54,8 @@ public class CardServiceTest {
         mockWebServer.enqueue(response);
 
         try {
-            List<Card> cards = service.getAllCards("oKthRbLqoXZr5NNua","iA6pmp6fENvF7AaTX").
+            List<Card> cards = service.getAllCards("oKthRbLqoXZr5NNua","iA6pmp6fENvF7AaTX")
-                    execute().body();
+                    .execute().body();
 
             assertNotNull(cards);
             assertEquals("Numbero of card not ok",2, cards.size());

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/ChecklistServiceTest.java

@@ -1,9 +1,15 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
+import static junit.framework.TestCase.assertNotNull;
+import static org.junit.Assert.assertEquals;
+
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Checklist;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.ChecklistItem;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.ChecklistItemStatus;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.ChecklistPrototype;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import org.junit.After;
@@ -12,12 +18,6 @@ import org.junit.Test;
 import retrofit2.Retrofit;
 import retrofit2.converter.gson.GsonConverterFactory;
 
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
-import static org.junit.Assert.*;
-
 public class ChecklistServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private ChecklistService service = null;
@@ -59,8 +59,8 @@ public class ChecklistServiceTest {
         try {
             List<Checklist> checklists = service.getAllChecklists(
                     "board id", "card id"
-            ).
+            )
-                    execute().body();
+                    .execute().body();
 
             assertNotNull(checklists);
             assertEquals(2, checklists.size());

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/ListServiceTest.java

@@ -1,6 +1,12 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
+import static junit.framework.TestCase.assertEquals;
+import static junit.framework.TestCase.assertNotNull;
+
 import it.unisannio.ding.ids.wedroid.wrapper.entity.WList;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import org.junit.After;
@@ -9,12 +15,6 @@ import org.junit.Test;
 import retrofit2.Retrofit;
 import retrofit2.converter.gson.GsonConverterFactory;
 
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
-import static org.junit.Assert.*;
-
 public class ListServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private ListService service = null;

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/SwimlanesServiceTest.java

@@ -1,7 +1,13 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
+import static junit.framework.TestCase.assertNotNull;
+import static org.junit.Assert.assertEquals;
+
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Color;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Swimlane;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import org.junit.After;
@@ -10,12 +16,6 @@ import org.junit.Test;
 import retrofit2.Retrofit;
 import retrofit2.converter.gson.GsonConverterFactory;
 
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
-import static org.junit.Assert.*;
-
 public class SwimlanesServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private SwimlanesService service = null;
@@ -62,6 +62,7 @@ public class SwimlanesServiceTest {
 
             for (int i = 0; i < 2; i++)
                 assertEquals("title " + (i + 1), lists.get(i).getTitle());
+
         } catch (IOException e) {
             e.printStackTrace();
         }
@@ -108,8 +109,8 @@ public class SwimlanesServiceTest {
         }
     }
 
-    final static String SWIMLANE_1 = "{\n\"_id\": \"BS4AA79YABBCpDDau\",\n\"title\": \"title 1\"\n}";
+    static final String SWIMLANE_1 = "{\n\"_id\": \"BS4AA79YABBCpDDau\",\n\"title\": \"title 1\"\n}";
-    final static String SWIMLANE_2 = "{" +
+    static final String SWIMLANE_2 = "{" +
             "\"_id\":\"JNmpXKCupbtyPkYMG\"," +
             "\"title\":\"title 2\"," +
             "\"boardId\":\"TtjXrJyvPkG3xsbkw\"," +

wrapper/src/test/java/it/unisannio/ding/ids/wedroid/wrapper/api/UserServiceTest.java

@@ -1,25 +1,25 @@
 package it.unisannio.ding.ids.wedroid.wrapper.api;
 
+import static junit.framework.TestCase.assertNotNull;
+import static junit.framework.TestCase.assertTrue;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+
 import it.unisannio.ding.ids.wedroid.wrapper.entity.Service;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.User;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.UserEmail;
 import it.unisannio.ding.ids.wedroid.wrapper.entity.UserProfile;
+import java.io.IOException;
+import java.net.HttpURLConnection;
+import java.util.List;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
-import static org.junit.Assert.*;
-
-import retrofit2.Call;
 import retrofit2.Retrofit;
 import retrofit2.converter.gson.GsonConverterFactory;
 
-import javax.jws.soap.SOAPBinding;
-import java.io.IOException;
-import java.net.HttpURLConnection;
-import java.util.List;
-
 public class UserServiceTest {
     private MockWebServer mockWebServer = new MockWebServer();
     private UserService service = null;
@@ -68,8 +68,7 @@ public class UserServiceTest {
             assertEquals("noemi", users.get(1).getUsername());
             assertEquals("jPdkf3a9bmfZWx3GR", users.get(2).getId());
             assertEquals("umberto", users.get(2).getUsername());
-        }
+        } catch (IOException e) {
-        catch (IOException e){
             e.printStackTrace();
         }
     }
@@ -185,7 +184,7 @@ public class UserServiceTest {
             "}\n" +
             "}";
 
-    private final String user2 = "{" +
+    private static final String user2 = "{" +
             "\"_id\":\"jPdkf3a9bmfZWx3GR\"," +
             "\"createdAt\":\"2019-10-14T18:14:38.249Z\"," +
             "\"username\":\"umberto\"," +