kanban/wedroid
2
0
Fork 0
Code Issues 4 Pull Requests Releases 1 Wiki Activity

feature_board_view #28

Merged
norangebit merged 19 commits from feature_board_view into develop 2020-01-16 18:33:24 +00:00
Conversation 0 Commits 19 Files Changed 30 +1486 -14
UmbertoF commented 2020-01-15 20:55:11 +00:00
Owner
Copy Link
No description provided.
norangebit requested changes 2020-01-16 17:27:51 +00:00
app/build.gradle Outdated
@ -69,6 +71,7 @@ dependencies {
androidTestImplementation 'androidx.test.ext:junit:1.1.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
androidTestImplementation 'androidx.test.espresso:espresso-contrib:3.2.0'
androidTestImplementation 'androidx.test.espresso:espresso-intents:3.2.0'
norangebit commented 2020-01-16 17:24:46 +00:00
Owner
Copy Link

where this dependency has been used?

where this dependency has been used?
UmbertoF commented 2020-01-16 17:45:00 +00:00
Author
Owner
Copy Link

this dependecies are not used, I delete them.

this dependecies are not used, I delete them.
app/build.gradle
@ -79,2 +82,4 @@
androidTestImplementation "androidx.arch.core:core-testing:$rootProject.androidxArchVersion"
androidTestImplementation "androidx.arch.core:core-testing:$rootProject.coreTestingVersion"
testImplementation 'org.mockito:mockito-core:2.19.0'
norangebit commented 2020-01-16 17:25:21 +00:00
Owner
Copy Link

Where this dependency has been used?

Where this dependency has been used?
app/src/main/java/it/unisannio/ding/ids/wedroid/app/view/BoardViewActivity.java
@ -0,0 +59,4 @@
Intent i = getIntent();
idBoard = i.getStringExtra("idBoard");
getListsButton = findViewById(R.id.getLists);
norangebit commented 2020-01-16 17:27:13 +00:00
Owner
Copy Link

I think it would be better to group all these findViewById in one function to make the code more readable.

I think it would be better to group all these `findViewById` in one function to make the code more readable.
UmbertoF commented 2020-01-16 17:40:54 +00:00
Author
Owner
Copy Link

ok, I review it

ok, I review it
norangebit approved these changes 2020-01-16 18:33:16 +00:00
norangebit closed this pull request 2020-01-16 18:33:24 +00:00
norangebit deleted branch feature_board_view 2020-01-16 18:33:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kanban/wedroid#28
No description provided.
Delete Branch "feature_board_view"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?